Color getTextColor() {
Color c = new Color(...);
if (this.state < 2) {
c = new Color(...);
}
return c;
}
Avoid creating an object until you know what you want:
Color getTextColor() {
Color c = null;
if (this.state < 2) {
c = new Color(...);
} else {
c = new Color(...);
}
return c;
}
Now, let's look at yours:
public PageIterator getForums(int start, int count) {
PageIterator pageIterator = new PageIterator();
try {
pageIterator = forumDao.getForums(start, count);
} catch (Exception ex) {
logger.error(ex);
}
return pageIterator;
}
Perhaps, rethrow exception will be perfect.